Tweaks for auth middleware tests: Focused + parallel + conventions #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows up #390 with a couple tweaks for the tests: * Make auth middleware tests more focused so they only test `authMiddleware` rather than the full server HTTP stack. * Remove use of `t.Setenv` so we can run all tests in parallel. * Use `pathPrefix` in middleware so that only the specific configured prefix is accepted rather than any prefix that might be present. * Use `CamelCaseTestName` convention rather than "test name like this". * Use `testBundle` convention for `setup`.
Collaborator
Author
|
Yeah that should work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #390 with a couple tweaks for the tests:
Make auth middleware tests more focused so they only test
authMiddlewarerather than the full server HTTP stack.Remove use of
t.Setenvso we can run all tests in parallel.Use
pathPrefixin middleware so that only the specific configuredprefix is accepted rather than any prefix that might be present.
Use
CamelCaseTestNameconvention rather than "test name like this".Use
testBundleconvention forsetup.