Add test showing round trip out job output #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was working on another job output related change, found myself becoming quite confused by the way it was implemented, and further found that it doesn't have much in the way of testing through `Output` (only a couple unit tests on `JobRow`) so it was hard to verify that what I was changing was producing the expected result. Here, add a "round trip" on job output for the client that records output in a work function, then retrieves the row and checks `Output` on it.
brandur
force-pushed
the
brandur-output-round-trip
branch
from
f227731 to
3e06543
Compare
bgentry
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on another job output related change, found myself
becoming quite confused by the way it was implemented, and further found
that it doesn't have much in the way of testing through
Output(only acouple unit tests on
JobRow) so it was hard to verify that what I waschanging was producing the expected result.
Here, add a "round trip" on job output for the client that records
output in a work function, then retrieves the row and checks
Outputonit.