Skip to content

feat: exposed file_size_in_bytes #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 30, 2025

Conversation

xxhZs
Copy link

@xxhZs xxhZs commented May 6, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Are these changes tested?

xxhZs and others added 6 commits May 6, 2025 17:23
@xxhZs xxhZs force-pushed the xxh/support-datafusion-0325 branch from 9346847 to 46b61bf Compare May 14, 2025 04:28
@Li0k Li0k requested review from chenzl25 and Li0k May 23, 2025 09:27
@Li0k Li0k changed the title feat: support rewrite trans and datafusion support feat: datafusion support May 23, 2025
@Li0k Li0k changed the title feat: datafusion support feat: exposed file_size_in_bytes May 23, 2025
Copy link
Collaborator

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this PR?

Copy link
Collaborator

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@@ -15,5 +15,5 @@
// specific language governing permissions and limitations
// under the License.

pub(crate) mod expr_to_predicate;
pub mod expr_to_predicate;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataFusion requires a conversion method in this mod

@@ -21,7 +21,7 @@ pub use catalog::*;
mod error;
pub use error::*;

mod physical_plan;
pub mod physical_plan;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@xxhZs xxhZs merged commit eece1b1 into dev_rebase_main_20250325 May 30, 2025
16 of 21 checks passed
@xxhZs xxhZs deleted the xxh/support-datafusion-0325 branch May 30, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants