-
Notifications
You must be signed in to change notification settings - Fork 1
feat: exposed file_size_in_bytes #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
9346847
to
46b61bf
Compare
…avelabs/iceberg-rust into xxh/support-datafusion-0325
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
@@ -15,5 +15,5 @@ | |||
// specific language governing permissions and limitations | |||
// under the License. | |||
|
|||
pub(crate) mod expr_to_predicate; | |||
pub mod expr_to_predicate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataFusion requires a conversion method in this mod
@@ -21,7 +21,7 @@ pub use catalog::*; | |||
mod error; | |||
pub use error::*; | |||
|
|||
mod physical_plan; | |||
pub mod physical_plan; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?