Skip to content

feat: support rewrite manifest #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev_rebase_main_20250307
Choose a base branch
from

Conversation

ZENOTME
Copy link

@ZENOTME ZENOTME commented Mar 20, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Are these changes tested?

@ZENOTME ZENOTME force-pushed the zj/rwrite_manifest branch from ed59493 to 8ef9be4 Compare March 20, 2025 14:14
@ZENOTME ZENOTME requested review from chenzl25, Li0k and xxchan March 21, 2025 04:06
@Li0k Li0k requested a review from Copilot May 22, 2025 10:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for manifest rewriting by registering a new integration test and extending the manifest model with hashing and a deleted-files check.

  • Registers rewrite_manifest_test in the shared integration tests
  • Derives Eq and Hash on key manifest structs/enums and adds has_deleted_files to ManifestFile

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/integration_tests/tests/shared_tests/mod.rs Added mod rewrite_manifest_test; to include the new test module
crates/iceberg/src/spec/manifest_list.rs Derived Eq, Hash on ManifestFile, ManifestContentType, FieldSummary and added has_deleted_files method
Comments suppressed due to low confidence (2)

crates/iceberg/src/spec/manifest_list.rs:594

  • Add unit tests for has_deleted_files covering cases where deleted_files_count is None, Some(0), and Some(>0) to verify correct behavior.
pub fn has_deleted_files(&self) -> bool {

crates/integration_tests/tests/shared_tests/mod.rs:34

  • Ensure that rewrite_manifest_test.rs exists in crates/integration_tests/tests/shared_tests/ and is named correctly to avoid a missing-module compilation error.
mod rewrite_manifest_test;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant