workflows: build-onnx: add - #204
Conversation
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
|
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
The cp312 build produces a stable ABI wheel that works for cp313 and cp314, so we only need a separate build for cp314t. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
| # but Pillow has no riscv64 wheel on public PyPI yet, so our | ||
| # registry is used. | ||
| CIBW_ENVIRONMENT_PASS_LINUX: PIP_EXTRA_INDEX_URL | ||
| CIBW_TEST_COMMAND: "pytest -k 'not maxpool_2d_uint8_cpu' {project}/onnx/test" |
There was a problem hiding this comment.
nit: can you explain why we need to skip this test?
| @@ -0,0 +1,144 @@ | |||
| --- | |||
| name: Build onnx wheels (riscv64) | |||
There was a problem hiding this comment.
would be very nice to have a link to the upstream workflow this file is based on. This will help review and traceability (make sure to link to a specific revision)
|
Not strictly related to this PR, but the doc preview should run only on PR modifying documentation (I.e files under docs) |
| gitlab-username: ${{ vars.GITLAB_DEPLOY_USER }} | ||
| gitlab-token: ${{ secrets.GITLAB_DEPLOY_TOKEN }} | ||
| gitlab-project-id: ${{ vars.GITLAB_PROJECT_ID }} | ||
| gh-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
nit: not strictly related to this PR, but can't this be the default values? so we would avoid copying it on every workflow file?
| python -m abi3audit -v "$whl" | ||
| done | ||
|
|
||
| publish: |
There was a problem hiding this comment.
not strictly related to this PR, but what about having a ./.github/workflows/deploy.yml workflow that would contains this to avoid copying it in each individual workflow?
The other benefit is that inside this file we could do something like:
- name: Deploy${{ github.ref != 'refs/heads/main' && ' (dry run)' || '' }}
uses: ./.github/actions/deploy
with:
dry-run: ${{ github.ref != 'refs/heads/main' }}
So the name of the job will actually contain "(dry run)" . Right now, we have the impression that the publish job succeeded and correctly uploaded file on the registry
| @@ -0,0 +1,144 @@ | |||
| --- | |||
There was a problem hiding this comment.
missing copyright:
| --- | |
| # SPDX-FileCopyrightText: 2026 The RISE Project | |
| # SPDX-License-Identifier: MIT | |
| --- |
2 participants
No description provided.