Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better description of how etrigger matches. #1085

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Better description of how etrigger matches. #1085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7df37d
Better description of how etrigger matches.
pdonahue-ventana Nov 20, 2024
1597023
Provide more clarity to address review feedback.
pdonahue-ventana Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions xml/hwbp_registers.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,9 @@ same project unless stated otherwise.

This register is accessible as {csr-tdata1} when {tdata1-type} is 4.

This trigger can fire when an interrupt trap is taken.
This trigger will fire when an interrupt trap is taken and the
corresponding {csr-tdata2} bit is set as described in the next
paragraph.

It can be enabled for individual interrupt numbers by setting the bit
corresponding to the interrupt number in {csr-tdata2}. The interrupt
Expand Down Expand Up @@ -1252,11 +1254,15 @@ same project unless stated otherwise.

This register is accessible as {csr-tdata1} when {tdata1-type} is 5.

This trigger may fire on up to XLEN of the Exception Codes defined in
`mcause` (described in the Privileged Spec, with Interrupt=0). Those
causes are configured by writing the corresponding bit in {csr-tdata2}.
(E.g. to trap on an illegal instruction, the debugger sets bit 2 in
{csr-tdata2}.)
This trigger will match when an exception trap is taken and the
corresponding {csr-tdata2} bit is set as described in the next
paragraph.

The trigger may be configured to match on up to XLEN of the Exception
Codes defined in `mcause` (described in the Privileged Spec, with
Interrupt=0). Those causes are configured by writing the corresponding
bit in {csr-tdata2}. (e.g. to have etrigger match on an illegal
instruction trap, the debugger sets bit 2 in {csr-tdata2}.)
Comment on lines +1261 to +1265
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still doesn't say that the trigger matches when an exception is taken, which is what your change description says you wanted to accomplish.


[NOTE]
====
Expand Down