-
Notifications
You must be signed in to change notification settings - Fork 76
fix: ssrdp.yaml file reference in mop.r.n.yaml #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
>> >> ssrdp instruction is in Zicfiss directory, not Zicfilp. >> >> - Fix: inst/Zicfilp/ssrdp.yaml# → inst/Zicfiss/ssrdp.yaml# Signed-off-by: Sukuna0007Abhi <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for fixing. If you are up to it, it would be great to add a validation check to catch this in the future. An instruction-specific validation would be in # don't take this literally; it probably belongs in a loop
hint_inst = ref(@data["hints"][0])If you put it here, it will be covered by CI checks. If you are really ambitious, you could also try to validate all refs by walking the database and dereferencing everything ref you find. |
|
Sure sir @dhower-qc, I will do this, Thanks for suggesting |
Add validation to Udb::Instruction#validate method to check all hint entries by dereferencing them. This catches broken hint references early in the validation pipeline and provides clear error messages showing the specific instruction and hint index that failed. The validation runs as part of existing CI checks and will prevent future broken hint references from being introduced. Addresses mentor feedback on adding ref validation to catch issues like the recent inst/Zicfilp/ssrdp.yaml# -> inst/Zicfiss/ssrdp.yaml# fix. Signed-off-by: Sukuna0007Abhi <[email protected]>
Yes sir I will create another PR which will validate all refs and resolves this type errors for not showing anymore in future |
|
Ready for Review sir @ThinkOpenly sir @dhower-qc |
|
I'm still learning Ruby, but it looks good to me. Did you test it, @Sukuna0007Abhi ? (Did it find any other issues?) |
Yes sir @ThinkOpenly I tested it and this issue find when working on PR #1064 and there are some other refs errors for which I will create another PR which automatically fix all the refs as sir @dhower-qc said |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some other refs errors
Great! This little piece of code has already proven its value!
|
Thanks sir @ThinkOpenly 🙏 but pls check my message it's need very much help for me 😞 |
I presume we should get that PR merged before this one, to prevent validation errors? |
Actually sir that's same like this but for all files refs in entire database. This PR is ok for this file I think And it's actually needed merged for #1064 |
And sir @ThinkOpenly sorry for disturb I actually talking about different message on different platform, needs kind help there also 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Fixes: #1065
Fix incorrect file reference in mop.r.n.yaml hints section
Problem
The
mop.r.n.yamlfile contains an incorrect file reference in its hints section that points to a non-existent file path:Solution
it should point to Zicfiss,
hints:
Ready for Review sir @ThinkOpenly sir @dhower-qc