target/riscv: Consistent data type for trigger indexes #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmetic detail: Use `unsigned int` to index triggers (as opposed to riscv_reg_t), which corresponds to the data type of `trigger_count` in `struct riscv_info_t`. Change-Id: I83539abdffa41aec2060fbd0c81496ab9607c9ea Signed-off-by: Jan Matyas <[email protected]>
en-sc
requested changes
Oct 3, 2024
There was a problem hiding this comment.
IMHO, it's better to use riscv_reg_t. Trigger index is the value of tselect. AFAIK, the spec allows for any number of triggers that should fit into tselect (up to 2^XLEN).
Current OpenOCD version limits the number of triggers, but this limit is completely arbitrary.
Thanks for your reply. I agree and I am closing this merge request. I have started looking at the data types more broadly with the hope that I have submitted first two merge requests on that topic already:
I plan to submit more related patches later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic detail: Use
unsigned intto index triggers (as opposed toriscv_reg_t), which corresponds tothe data type of
trigger_countinstruct riscv_info_t.Change-Id: I83539abdffa41aec2060fbd0c81496ab9607c9ea