Skip to content

WEB3-513: contracts: dependency cleanups #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Jul 29, 2025

  • Hide SetVerifierService behind feature
  • Use alloy-provided decode error functionality
  • alloy has been released in v1, so there is no immediate need anymore to expose it

@Wollac Wollac requested a review from a team as a code owner July 29, 2025 11:35
@github-actions github-actions bot changed the title contracts: dependency cleanups WEB3-513: contracts: dependency cleanups Jul 29, 2025
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thank you for working taking care of this.

Comment on lines -20 to -25
/// Re-export of [alloy], provided to ensure that the correct version of the types used in the
/// public API are available in case multiple versions of [alloy] are in use.
///
/// Because [alloy] is a v0.x crate, it is not covered under the semver policy of this crate.
pub use alloy;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove this, because it might break downstream users and I think this is actually still helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants