1. Two Sum #11
Open
1. Two Sum #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodchip
reviewed
Apr 28, 2025
| ```python | ||
| class Solution: | ||
| def twoSum(self, nums: List[int], target: int) -> List[int]: | ||
| seen = {} |
There was a problem hiding this comment.
seen という変数名ですと、 key と value にどのような値が含まれているのか分かりにくいと感じました。 num_to_index 等、 (keyが表すもの)_to_(valueが表すもの) といった命名はいかがでしょうか？
| def twoSum(self, nums: List[int], target: int) -> List[int]: | ||
| seen = {} | ||
| for i in range(len(nums)): | ||
| needed_value = target - nums[i] |
There was a problem hiding this comment.
nums を使っているので、needed_num もありかなと感じました。
oda
reviewed
Apr 30, 2025
| - https://github.com/fhiyo/leetcode/pull/14/files?short_path=050f7e8#diff-050f7e8a6e8dcab5ada34b1061c96b59923387f92e6582826703e46c59d73557 | ||
|
|
||
| - enumerateを使うやり方を紹介している人がいたが、本質的には変わらないなと思ったため実装は割愛する。 | ||
| - 引き算をして何かをするというのは発送として持っていたが実装に活かせなかった。 |
There was a problem hiding this comment.
私がいいたいことはこれくらいです。
「あなたは部屋に入りました。数字の一つ書かれた紙を1000枚あります。その中から和が5000になる2枚を見つけてください。」というときに、100万回足し算しますかねえ。
https://discord.com/channels/1084280443945353267/1183683738635346001/1187304667126976532
どんどん先に進みましょう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.