Skip to content

Fix install script for non-interactive environments #9064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
begelundmuller merged 1 commit into from
Mar 16, 2026
Merged

Fix install script for non-interactive environments #9064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,30 @@ testInstalledBinary() {

# Print 'rill start' help intrcutions
printStartHelp() {
boldon=$(tput smso)
boldoff=$(tput rmso)

if [ "$INSTALL_DIR" = "/usr/local/bin" ]; then
printf "\nTo start a new project in Rill, execute the command:\n\n %srill start my-rill-project%s\n\n" "$boldon" "$boldoff"
elif [ "$INSTALL_DIR" = "$HOME/.rill" ]; then
printf "\nTo start a new project in Rill, open a %snew terminal%s and execute the command:\n\n %srill start my-rill-project%s\n\n" "$boldon" "$boldoff" "$boldon" "$boldoff"
# Resolve how to reference the binary in help text.
if [ "$INSTALL_DIR" = "/usr/local/bin" ] || [ "$INSTALL_DIR" = "$HOME/.rill" ]; then
binary="rill"
elif [ "$INSTALL_DIR" = "$(pwd)" ]; then
printf "\nTo start a new project in Rill, execute the command:\n\n %s./rill start my-rill-project%s\n\n" "$boldon" "$boldoff"
binary="./rill"
else
binary="$INSTALL_DIR/rill"
fi

# Print instructions for non-interactive callers.
if [ "$NON_INTERACTIVE" = "true" ]; then
printf "\nTo initialize a new project, run '%s init'. Run '%s -h' for an overview of available commands.\n" "$binary" "$binary"
return
fi

# Safely get bold formatting codes.
boldon=$(tput smso 2>/dev/null) || boldon=""
boldoff=$(tput rmso 2>/dev/null) || boldoff=""

# Print instructions for interactive callers.
if [ "$INSTALL_DIR" = "$HOME/.rill" ]; then
printf "\nTo start a new project in Rill, open a %snew terminal%s and execute the command:\n\n %s%s start my-rill-project%s\n\n" "$boldon" "$boldoff" "$boldon" "$binary" "$boldoff"
else
printf "\nTo start a new project in Rill, execute the command:\n\n %s%s start my-rill-project%s\n\n" "$boldon" "$binary" "$boldoff"
fi
}

Expand Down Expand Up @@ -264,7 +279,9 @@ resolveInstallDir() {

# Install Rill on the system
installRill() {
publishSyftEvent install
if [ "$NON_INTERACTIVE" != "true" ]; then
publishSyftEvent install
fi
checkDependency curl
checkDependency unzip
checkGitDependency
Expand All @@ -277,9 +294,9 @@ installRill() {
testInstalledBinary
if [ "$NON_INTERACTIVE" != "true" ]; then
addPathConfigEntries
publishSyftEvent installed
fi
printStartHelp
publishSyftEvent installed
}

# Uninstall Rill from the system, this function is aware of both the privileged and unprivileged install methods
Expand Down
Loading