Skip to content

Add install script ShellCheck to CI/CD #9044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaspersjo merged 7 commits into from
Mar 13, 2026
Merged

Add install script ShellCheck to CI/CD #9044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99353de
Add install script ShellCheck to CI/CD
kaspersjo Mar 13, 2026
5c9bf10
Add missing double quotes to install script
kaspersjo Mar 13, 2026
40b7a63
Fix typo in script path
kaspersjo Mar 13, 2026
e2428cd
Change to install and use ShellCheck directly
kaspersjo Mar 13, 2026
3c4b04f
Add missing double quotes to install script
kaspersjo Mar 13, 2026
ac8a898
Fix format
kaspersjo Mar 13, 2026
40caed3
Remove unsafe variable expansion
kaspersjo Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/install-script-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Check install script

on:
pull_request:
paths:
- 'scripts/install.sh'

jobs:
shellcheck:
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Install ShellCheck
run: sudo apt-get update && sudo apt-get install -y shellcheck

- name: Run ShellCheck on install script
run: |
shellcheck --shell=dash scripts/install.sh
8 changes: 4 additions & 4 deletions scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,16 @@ downloadBinary() {
CHECKSUM_URL="https://${CDN}/rill/${VERSION}/checksums.txt"

if [ "$NON_INTERACTIVE" = "true" ]; then
CURL_PROGRESS="--silent --show-error"
set -- "--silent" "--show-error"
else
CURL_PROGRESS="--progress-bar"
set -- "--progress-bar"
fi

printf "Downloading binary: %s\n" "$BINARY_URL"
curl --location ${CURL_PROGRESS} "${BINARY_URL}" --output rill_${PLATFORM}.zip
curl --location "$@" "${BINARY_URL}" --output rill_${PLATFORM}.zip

printf "\nDownloading checksum: %s\n" "$CHECKSUM_URL"
curl --location ${CURL_PROGRESS} "${CHECKSUM_URL}" --output checksums.txt
curl --location "$@" "${CHECKSUM_URL}" --output checksums.txt

printf "\nVerifying the SHA256 checksum of the downloaded binary:\n"
${sha256_verify} checksums.txt
Expand Down
Loading