-
Notifications
You must be signed in to change notification settings - Fork 0
Two Sum #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Two Sum #8
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
//lint:file-ignore U1000 Ignore all unused code | ||
package twosum | ||
|
||
/* | ||
かなり前に解いたものなので詳細は忘れてしまいましたが、ナイーブにやる方法では各文字ごとに毎回リストを走査してしまうと時間計算量がO(n^2)になってしまうので、オーバーヘッドはありますが、ハッシュ化するのが良いと考えました。 | ||
|
||
また同じ要素を2回使うのを避けるために、毎回追加する前に対応する要素がないかを確認してから追加するようにしました。 | ||
*/ | ||
func twoSumStep1(nums []int, target int) []int { | ||
m := make(map[int]int) | ||
for i, n := range nums { | ||
if j, ok := m[target-n]; ok { | ||
return []int{i, j} | ||
} | ||
m[n] = i | ||
} | ||
return nil | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
//lint:file-ignore U1000 Ignore all unused code | ||
package twosum | ||
|
||
/* | ||
mではなく、よりわかりやすいようにnumsMapとしました。 | ||
GoogleのGoスタイルガイドには変数名に型名を使うのは良くないと書かれていますが、同時に下記のようにも書かれています。今回はnumsという配列をマップに変換したもの(配列もインデックスと値を情報としてもつ)と捉えることができるため、対応していることを示すためにnumsMapとしました。 | ||
|
||
`It is acceptable to include a type-like qualifier if there are two versions of a value in scope, for example you might have an input stored in ageString and use age for the parsed value.` | ||
|
||
`numToIdx`というのもありそう(https://github.com/aoshi2025s/leetcode-review/pull/1#discussion_r1666780953)。 | ||
|
||
対応する組み合わせが見つからなかった際にどうするのかは難しいところ。 | ||
- https://github.com/seal-azarashi/leetcode/pull/11#discussion_r1672537855 | ||
- https://github.com/sendahuang14/leetcode/pull/11#discussion_r1702393602 | ||
*/ | ||
func twoSumStep2(nums []int, target int) []int { | ||
numsMap := make(map[int]int) | ||
for i, n := range nums { | ||
if j, ok := numsMap[target-n]; ok { | ||
return []int{i, j} | ||
} | ||
numsMap[n] = i | ||
rihib marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
return nil | ||
rihib marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
//lint:file-ignore U1000 Ignore all unused code | ||
package twosum | ||
|
||
func twoSumStep3(nums []int, target int) []int { | ||
numToIndex := make(map[int]int) | ||
for i, n := range nums { | ||
if j, ok := numToIndex[target-n]; ok { | ||
return []int{i, j} | ||
} | ||
numToIndex[n] = i | ||
} | ||
return nil // 本来ならerrorを返したい | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.