-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHubRepoURL value type #65
GitHubRepoURL value type #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Looks good
The CI fails, can you take a look into that? |
I changed my url import to Edit: Well, I don't know why the CI doesn't know url |
The error comes up because node 20 (used in the CI) does not have the |
And it's merged, so please merge the |
The value type accepts a URL with the following constraints as input: - protocol: `http` or `https` - hostname: `www.github.com` or `github.com` - pathname: structure of a repo, i. e. `/abc/def` SSH git URLs are unsupported as of now. If those should be considered in the future, the class structure probably has to be modified. Signed-off-by: Mr-Kanister <[email protected]>
Signed-off-by: Mr-Kanister <[email protected]>
d2c7a5c
to
a1f4729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This issue closes #28 .
The value type accepts a URL with the following constraints as input:
http
orhttps
www.github.com
orgithub.com
/abc/def
SSH git URLs are unsupported as of now. If those should be considered in
the future, the class structure probably has to be modified.
How can this be tested?
npm run test
Screenshots
No UI changes made.
Checklist