Vitest should now work properly #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
…ty far along the way, but reader exists only as a concept for now.
…ctFeatures.ts to keep the old client interface, but use new db scheme under the hood.
Merge Pull Request
… the concept from the actual "model" classes.
…se. Adjusted ObjectHandler to use the Reader where aplicable.
… and written to and from db and entity objects.
…ded a getUserCount() Method to ObjectHandler.
… to getTableNameFromClass.
…ata. Use ProjectManager to interact with user_projects relation!
… membership logic from User and CourseProject, please use the Manager for this!
…ourses and CourseProjects. (this makes Serializable creation easier, because we dont have to touch the factory)
7 tasks
|
Sorry, my mistake. I continued working on my second task and simply took over the PR. Should I close this one? |
|
Either that or force push, whatever you prefer, I don't mind. Since you work on #62 you can also just implement it there and close this PR. I assume there are just two lines changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue closes #55.
Summary
As far as I understand it, the
vitest runcommand implicitly searches for test files and executes them all if they are in thesrc/tests/...directory. Due to the design of the mono-repository, it is sufficient to specify the--prefix client/serverin ourpackage.jsonroot. Or that is exactly the reason why vitest run is sufficient. Anyway, if we want it more explicit, then we should rather think about configuring the workspace(s) as an option, e.g. if we want specific tests for each environment.If there are no files, the test will fail, so I've decided to leave the
client/.../dummy.test.tsthere and will be sure to provide a test file for my widget later :)How can this be tested?
Go to the root directory
cd mini-mecoand executenpm run testin the console.Screenshots
No UI changes were made
Checklist