Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #23 Add Course and CourseProject classes Part 1 #53

Closed
wants to merge 6 commits into from

Conversation

SirJonithan
Copy link
Contributor

This pull request implements the domain model classes for Course and CourseProject as well as a "ProjectMember" class which is imo necessary to work with Project memberships properly on a domain-level.
I wanted to integrate the structure first because i know other student's issues require the classes for their work.
For querying the related models i have not found to a good way to initialize these fields in a synchronous manner - would it be sufficient if provide asynchronous methods for fetching the related objects?
Also please let me know if it's in your interest to pursue the approach with the ProjectMember instances or if another approach would be superior.

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@joluj joluj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution! 2 small changes are required, but they both are a quick fix :)

Please make sure to use our pull request template. Usually the PR's description box should have been prefilled with this content. Was that not working?


For querying the related models i have not found to a good way to initialize these fields in a synchronous manner - would it be sufficient if provide asynchronous methods for fetching the related objects?

I'm not sure if I understand the question correctly. Usually you fetch data from the DB and use that result to create the related object. Only the DB operation is asynchronous, the object creation and using the object can stay synchronous. Did I misunderstand something?


Also please let me know if it's in your interest to pursue the approach with the ProjectMember instances or if another approach would be superior.

@dirkriehle Do you have a preference?

@fhilgers fhilgers mentioned this pull request Feb 9, 2025
8 tasks
@SirJonithan SirJonithan closed this Feb 9, 2025
@SirJonithan
Copy link
Contributor Author

SirJonithan commented Feb 9, 2025

Requested fixes were made, Changes are included in PR #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants