-
Notifications
You must be signed in to change notification settings - Fork 4
Fixed the styling on blog index and fixed the project index, listed the projects on the home page and fixed the blog show page #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rt-prexus
Are you sure you want to change the base?
Conversation
…he projects on the home page
@hasannadeem there is one failing spec right now. |
Sure, I am fixing the spec, but I just double-checked it, and it’s not failing because of my changes. |
Hey @ronaldtse, I have fixed the specs as well. |
Hey @ronaldtse, i have tested this pr on https://github.com/rnpgp/rnpgp.github.io. I first tried to running the project with the existing code(not with ![]() Then I ran the project(https://github.com/rnpgp/rnpgp.github.io.) with this pr and it is working smoothly. As you can see in the screenshoots. ![]() ![]() |
On the rnpgp page, are we missing the landing/hero image? It needs to look like the current website at www.rnpgp.org. Thanks! |
Also @hasannadeem could you help test it on the hub site (https://github.com/riboseinc/open.ribose.com/)? Thanks! |
Hey @ronaldtse, which hero image are you referring here? Could you please specify or attach a SS? |
Hey @ronaldtse, i have tested the hub site with the rename gem pr and here is the SS. ![]() I have also tested the hub site with my PR and here is the SS. ![]() |
![]() The PR was incomplete, that's why it was broken. We can only merge the PR when it is complete (i.e. the sites render properly as I've shown in screenshots). Thanks. |
@hasannadeem I just realized that actually nothing is fixed here. This is the reason that I mentioned to actually test with actual sites not just the specs/ because it is possible to misunderstand what the specs mean. The specs do not mean that you "add a sample image to the gem and them use it to pass tests", this is the reason why there is "no sample image at the /assets directory of the gem". The symbol.svg file is meant to be read from "not the gem" but from the actual (hub or project) site that "uses the gem". I don't know how I can explain further here. |
Projects are now listed on the project index page, and they are also being indexed on the home page.
The blog index page was not working properly before — that’s now fixed as well.
Blog show page fix