Upgrade to easyfft v0.3 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this requires an extra Default trait bound which results in requiring a major version change for fftconvolve. Practically it's not an issue since all elements that you'd want to convolve would implement Default, but it's a bit annoying. Default is required for initializing the scratch-buffer, which is strictly not necessary but requires changes to `rustfft`. It's currently pending this issue in rustfft: ejmahler/RustFFT#105
WalterSmuts
force-pushed
the
easyfft-upgrade
branch
from
6b5f9c1 to
c6fbb33
Compare
|
Easy as, but should this wait until that RustFFT issue is resolved or do you reckon it is good to go now? |
|
I don't think the issue will be resolved anytime soon so I would recommend to merge for now. Unfortunately it means a major version change for If the issue get's resolved, it would mean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this requires an extra Default trait bound which results in requiring a major version change for fftconvolve.
Practically it's not an issue since all elements that you'd want to convolve would implement Default, but it's a bit annoying.
Default is required for initializing the scratch-buffer, which is strictly not necessary but requires changes to
rustfft. It's currently pending this issue in rustfft:ejmahler/RustFFT#105