chore: add scripts/go.mod and scripts/go.sum to restore upstream #105
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
machine424
reviewed
Feb 5, 2025
| @@ -27,6 +28,8 @@ jobs: | |||
| example | |||
| go.mod | |||
| go.sum | |||
| scripts/go.mod | |||
There was a problem hiding this comment.
I'd like to know more about why those are needed now
There was a problem hiding this comment.
I tried manually to sync and it there were merge conflicts due to the addition of toolchain go1.23.3 . It should have been added previously too but we don't get much conflict on this so never needed.
https://github.com/prometheus-operator/prometheus-operator/blob/main/scripts/go.mod#L5
https://github.com/openshift/prometheus-operator/blob/main/scripts/go.mod#L5
There was a problem hiding this comment.
See from recent run https://github.com/rhobs/syncbot/actions/runs/13153490415/job/36705315910 as well
Signed-off-by: Jayapriya Pai <[email protected]>
slashpai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.