Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: chore(prometheus): impose downstream .gitignore in case of conflicts to ensure keeping track of the generated UI assets #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

machine424
Copy link
Contributor

No description provided.

…to ensure keeping track of the generated UI assets
@machine424 machine424 requested a review from a team as a code owner January 6, 2025 14:12
@jan--f
Copy link
Contributor

jan--f commented Jan 23, 2025

hmm do we not want to manually resolve conflicts like this? If we always restore this on conflicts we might miss additions we might want.
Wouldn't it be better to adjust our assets generation and perhaps fix our gitignore so that it doesn't cause a conflict?

@machine424
Copy link
Contributor Author

hmm do we not want to manually resolve conflicts like this? If we always restore this on conflicts we might miss additions we might want. Wouldn't it be better to adjust our assets generation and perhaps fix our gitignore so that it doesn't cause a conflict?

Yep, the gitignore will be adjusted as part of openshift/prometheus#227

The suggestion here (still a WIP, not sure if we want to go with it) is just to avoid having to address conflicts for cosmetic upstream changes, if the override doesn't work and human intervention is needed, something should be broken somewhere and we'll be aware of that (CI not passing e.g.)

But yes, we can do without this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants