OU-1472: remove "incident" feature flag from monitoring backend

[PeterYurkovich]

Since the monitoring-console-plugin deployment handles the incidents and cluster-health-analyzer feature flags as the same thing this change updates the observability operator to only send the cluster-health-analyzer flag to reduce the need to maintain the incidents flag on the monitoring-console-plugin backend.

This does not change the CR for the UIPlugin, as our team is planning to create a v1 or v1alpha2 version of the CR in the somewhat near future and this merging within the CR should occur there so we don't need to have a second webhook to maintain.

PR may look unrelated to the jira ticket, but it a part of the step to remove unneeded feature flags to create a better mapping between the features and the files being tested for automation to pick up on. Related PR openshift/monitoring-plugin#1127

[openshift-ci-robot]

@PeterYurkovich: This pull request references OU-1472 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Since the monitoring-console-plugin deployment handles the incidents and cluster-health-analyzer feature flags as the same thing this change updates the observability operator to only send the cluster-health-analyzer flag to reduce the need to maintain the incidents flag on the monitoring-console-plugin backend.

This does not change the CR for the UIPlugin, as our team is planning to create a v1 or v1alpha2 version of the CR in the somewhat near future and this merging within the CR should occur there so we don't need to have a second webhook to maintain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3356c5a5-4dd5-46bc-8503-2d697c662aef

📥 Commits

Reviewing files that changed from the base of the PR and between 261b086 and 54798e6.

📒 Files selected for processing (2)

• pkg/controllers/uiplugin/monitoring.go
• pkg/controllers/uiplugin/monitoring_test.go

---

📝 Walkthrough

Walkthrough

The monitoring controller now enables cluster-health-analyzer and sets its image when incidents or Cluster Health Analyzer configuration is valid. Tests add Cluster Health Analyzer fixtures and assertions for feature flags, component states, images, and version-specific behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 54798

This change narrows the monitoring backend feature flags to cluster-health-analyzer; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: jgbernalp, simonpasquier

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies removal of the incident feature flag from the monitoring backend.
Description check	✅ Passed	The description explains the feature-flag change, its scope, and its relationship to the referenced Jira issue.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[etmurasaki]

tested with/without incidents feature. working fine.

[zhuje]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/controllers/uiplugin/OWNERS [PeterYurkovich,zhuje]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment