Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tenancy by creating new PrometheusRule obj for Thanos Operator #36

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

saswatamcode
Copy link
Member

@saswatamcode saswatamcode commented Jan 22, 2025

This changes the PrometheusRule syncer path to do the following,

  • Removes obsctl operations (setting tenant context, and then setting rules), after collecting PrometheusRule objects and splitting tenants
  • Replaces this with a function that creates a new PrometheusRule object for each tenant with rule groups pertaining to that tenant. It also uses prom-label-proxy to inject tenant labels into the rules of the tenant
  • Also ensures that new PrometheusRule objects have Thanos Operator labels

This PR also updates Go version, lint tooling and a bunch of k8s, Prometheus Operator specific dependencies

@saswatamcode saswatamcode marked this pull request as ready for review February 25, 2025 09:17
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saswatamcode saswatamcode merged commit a9fc477 into rhobs:main Feb 25, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants