OU-453: Add perses-operator to COO component for Konflux #463
Conversation
- Added submodule to link to perses/perses-operator by running `git submodule add https://github.com/perses/perses-operator` - TODO: 1) Need to point to a release branch for perses-operator in .gitmodules file 2) Need to double check Dockerfile.perses-operator points at the right file paths
Add /perses-operator to .gitignore Add `ignore=all` flag to .gitmodules > submodule "perses-operator" so that it doesn't update the submodule when runnning `git submodule updates`. We'll need to remove the gitignore and manually push for each tag change to point at a new commit in the submodule. (current workaround the fact that there are no release branches in perses/perses-operator)
…perator has access to generate file "/perses-operator/bin/manager"
.gitmodules
Outdated
| url = https://github.com/perses/perses-operator.git | ||
| #branch = TBD release brach | ||
| # sub-module should point to tag v0.1.0 | ||
| ignore = all #ignore all `git submodule updates` to this submodule (will be manually updated to accomdate usage of tags) |
There was a problem hiding this comment.
manually updating might be cumbersome. We can create a release branch from the operator side
There was a problem hiding this comment.
I updated this to point at the release branch I created in /perses/perses-operator and will update the .gitmoduels to branch=release-v0.1.0.
https://github.com/perses/perses-operator/tree/release-v0.1.0 it points to the same commit as the tag v0.1.0 (e56893154adfc65e667efeb3a3a112042f1b28df)
Dockerfile.perses-operator
Outdated
| FROM alpine AS build-env | ||
| RUN apk add --update --no-cache mailcap | ||
|
|
||
| FROM gcr.io/distroless/static-debian12 |
There was a problem hiding this comment.
We might need to use redhat validated images.
There was a problem hiding this comment.
Update this file to mimic /perses/perses-operator/Dockerfile.dev
Updated to use equivalent redhat validated images. I think Dockerfile.obo is using similar images so I used those:
Before
FROM golang:1.23-alpine AS build-env
After
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_8_golang_1.22 as build-env
Before
FROM gcr.io/distroless/static-debian12
After
FROM registry.redhat.io/ubi8/ubi-minimal:8.10-1130
Dockerfile.perses-operator
Outdated
|
|
||
| USER nobody | ||
|
|
||
| COPY --chown=nobody:nobody perses-operator/bin/manager /bin/manager |
There was a problem hiding this comment.
This image asumes the binary is already built, we need to change it to one that actually builds the binary
There was a problem hiding this comment.
Update this file to mimic /perses/perses-operator/Dockerfile.dev
Updated to use equivalent redhat validated images. I think Dockerfile.obo is using similar images so I used those:
Before
FROM golang:1.23-alpine AS build-env
After
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_8_golang_1.22 as build-env
Before
FROM gcr.io/distroless/static-debian12
After
FROM registry.redhat.io/ubi8/ubi-minimal:8.10-1130
zhuje
changed the title
Update Dockerfile.perses-operator with redhat certified images and instructions to build the application (this is based on perses/perses-operator/Dockerfile.dev)
| @@ -0,0 +1,22 @@ | |||
| FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_8_golang_1.22 as build-env | |||
|
|
|||
| RUN apk add --update --no-cache make bash mailcap | |||
There was a problem hiding this comment.
This command might not work, or might be necessary anymore because we changed the image.
If we don't have access to the brew.registry.redhat.io registry -- then try to find an equivalent image.
Test with docker build to see if it succeeds.
Related JIRA:
https://issues.redhat.com/browse/OU-453