Skip to content

docs: Update "more options here" link in README #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jprenken
Copy link
Contributor

@jprenken jprenken commented Mar 8, 2025

The "more options here" link pointed to an old Revolt.toml commit showing options which have since changed. Point to the main branch instead.

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

The "more options here" link pointed to an old Revolt.toml commit showing options which have since changed. Point to the main branch instead.

Signed-off-by: James Renken <[email protected]>
@IAmTomahawkx
Copy link
Member

Hmm, I'm not sure about pointing to main, since that's usually ahead of what's live on self-hosted and may lead to confusion about added/renamed config keys. Manually updating the link every time an update is released is also far too tedious, so this needs a bit of pondering to figure out the best solution.

@insertish
Copy link
Member

Does GitHub maybe provide a way to point to the latest tagged release? That's usually a safe bet.

@insertish insertish moved this from 🆕 Untriaged to 🏗 In Progress in Pull Request Overview Apr 25, 2025
@insertish
Copy link
Member

It seems to only support tags, branches, and commit SHA.
Don't think it's worth automating unless if someone is interested.

Typically once something reaches main it is tagged relatively quickly for use (in theory) so maybe it's not an issue to just put main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

3 participants