Skip to content

fix: Update background filter and user badges in UserSummary #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function UserSummary(props: {
const bannerStyle = () =>
props.bannerUrl
? {
"background-image": `linear-gradient(rgba(255, 255, 255, 0.7), rgba(255, 255, 255, 0.7)), url("${props.bannerUrl}")`,
"background-image": `linear-gradient(var(--colours-settings-background-filter), var(--colours-settings-background-filter)), url("${props.bannerUrl}")`,
}
: {
background: `var(--colours-settings-background)`,
Expand Down Expand Up @@ -62,7 +62,7 @@ export function UserSummary(props: {
},
}}
>
<MdCakeFill {...iconSize(18)} />
<MdCakeFill {...iconSize(18)} fill={"currentColor"} />
</span>
</ProfileBadges>
</BottomBar>
Expand Down
1 change: 1 addition & 0 deletions packages/client/components/ui/styled.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ export interface DefaultTheme {
| "mention"}-${"background" | "foreground"}`}`}`
| `settings-${
| "background"
| "background-filter"
| "foreground"
| `content-${"background" | "foreground" | "scroll-thumb"}`
| `close-anchor${"" | "-hover"}`
Expand Down
4 changes: 4 additions & 0 deletions packages/client/components/ui/themes/darkTheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,10 @@ export const darkTheme: (

// Settings
"settings-background": materialColour("secondary", 92),
"settings-background-filter":
(darkMode)
? "rgba(0, 0, 0, 0.7)"
: "rgba(255, 255, 255, 0.7)",
"settings-foreground": materialColour("onSecondaryContainer"),
"settings-content-background": materialColour("secondary", 96),
"settings-content-foreground": materialColour("onSecondary", 20),
Expand Down