fix: correct docker-pull retry logic #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally written against exceptions, but we're calling a process and using the exit code to throw later, so it was never raising any exceptions at the point of our retry logic. Instead we should move it outside and use the non-exception `retrying` based on that exit code.
It's currently failing. It was also never needed here anyway, we only need to check that on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally written against exceptions, but we're calling a
process and using the exit code to throw later, so it was never raising
any exceptions at the point of our retry logic. Instead we should move
it outside and use the non-exception
retryingbased on that exit code.