Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule/#10/lowercase #12

Merged
merged 24 commits into from
Aug 16, 2022
Merged

Rule/#10/lowercase #12

merged 24 commits into from
Aug 16, 2022

Conversation

danielabajirov
Copy link
Collaborator

@danielabajirov danielabajirov commented Jul 26, 2022 •
edited
Loading

Description

With this pull request the implementation of the rule #10 will be merged with the main branch.

Fixes #10

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

5 tests have been written for this implementation. The first two tests check if the implementation detects the correct number of violations in a file. The third test checks if the implementation works with empty paths, the fourth with empty URIs and the last if no violations are detected on a valid file.

  • TcheckViolationOnInvalidRESTFile6Violations
  • checkViolationOnInvalidRESTFile3Violations
  • checkViolationOnInvalidRESTFileEmpty
  • checkViolationOnInvalidRESTFileEmptyURI
  • checkViolationOnValidFile

Test Configuration: JUnit 5

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • My changes generate no new warnings

danielabajirov and others added 11 commits August 7, 2022 22:30
@danielabajirov
Merge branch 'main' of https://github.com/manuelmerkel/Projektarbeit-…
3b13125 
…Master into rule/#10/lowercase

� Conflicts:
�	rest-studentproject/bin/main/rest/studentproject/rules/LowercaseRule.class
�	rest-studentproject/bin/test/rest/studentproject/rules/RestParserCommandTest.class
@danielabajirov
fix: fix merge conflict
902d709
@danielabajirov
fix: fix tests
4c6d1b1
@danielabajirov
Merge branch 'rule/#10/lowercase' of https://github.com/manuelmerkel/…
33661ce 
…Projektarbeit-Master into rule/#13/hyphens

� Conflicts:
�	rest-studentproject/bin/main/rest/studentproject/RestParserCommand.class
�	rest-studentproject/bin/main/rest/studentproject/analyzer/RestAnalyzer.class
�	rest-studentproject/bin/main/rest/studentproject/rules/IRestRule.class
�	rest-studentproject/src/main/java/rest/studentproject/RestParserCommand.java
�	rest-studentproject/src/main/java/rest/studentproject/analyzer/RestAnalyzer.java
�	rest-studentproject/src/main/java/rest/studentproject/rules/HyphensRule.java
�	rest-studentproject/src/main/java/rest/studentproject/rules/IRestRule.java
@danielabajirov
fix: fix merge conflicts. Update tests
0220b0e
@danielabajirov
fix: add loc to violation
7060f14
@BlueWaves2
Merge pull request #14 from manuelmerkel/rule/#13/hyphens
057d948 
Rule/#13/hyphens
@danielabajirov
fix: fix files
7beb222
@danielabajirov
Merge branch 'rule/#10/lowercase' of https://github.com/manuelmerkel/…
c2c54a5 
…Projektarbeit-Master into rule/#10/lowercase
@danielabajirov
fix: fix files for hyphens
0a18c4e
@danielabajirov
fix: delete bin folder
9ff2145
@manuelmerkel manuelmerkel self-assigned this Aug 12, 2022
@manuelmerkel manuelmerkel merged commit 380c5a2 into main Aug 16, 2022
@manuelmerkel manuelmerkel deleted the rule/#10/lowercase branch August 16, 2022 07:50
xJREB pushed a commit that referenced this pull request Aug 25, 2023
@manuelmerkel
Merge pull request #12 from manuelmerkel/rule/#10/lowercase
566f794 
Rule/#10/lowercase and Rule/#13/hyphens

Former-commit-id: cc839fb99cf47229aad7e59205544934a3211421 [formerly 380c5a2]
Former-commit-id: 4b4e840ca878af4888a9eea404be310af3f1575e
Former-commit-id: 77647d512bcf7466d76eb050ff59bcbda0d647e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelmerkel manuelmerkel manuelmerkel left review comments

Assignees

@manuelmerkel manuelmerkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lowercase letters should be preferred in URI paths
3 participants
@danielabajirov @manuelmerkel @BlueWaves2