Name oneOf variants after the value that selects them - #396
Open
tillrohrmann wants to merge 1 commit into
Open
Conversation
tillrohrmann
force-pushed
the
config-oneof-variant-labels
branch
from
September 1, 2026 11:10
f541d0d to
0953574
Compare
tillrohrmann
force-pushed
the
config-oneof-variant-labels
branch
2 times, most recently
from
September 1, 2026 21:02
36363de to
d6ca090
Compare
Variants were labelled "Option 1: None", "Option 2: Fixed delay", and the
`type` field inside each one rendered completely blank. Nothing on the page
said that picking one means writing `type = "exponential"`.
Variants are now named after that line, taken from the discriminator the
schema already carries as `"type": {"const": "exponential"}`. Scalar variants
had the same problem: log-format now offers `"pretty"` rather than
"Option 1: Pretty", because the const is preferred over the Rust title.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tillrohrmann
force-pushed
the
config-oneof-variant-labels
branch
from
September 1, 2026 21:08
d6ca090 to
af9e0f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variants were labelled "Option 1: None", "Option 2: Fixed delay", and the
typefield inside each one rendered completely blank. Nothing on the page said that picking one means writingtype = "exponential".Variants are now named after exactly that line, taken from the discriminator the schema already carries as
"type": {"const": "exponential"}.Scalar variants had the same problem for the same reason — the Rust title was preferred over the const — so
log-formatnow offers"pretty"rather than "Option 1: Pretty", andmax-attemptsoffers"unlimited"orinteger.Stack created with GitHub Stacks CLI • Give Feedback 💬