Skip to content
This repository was archived by the owner on Jul 31, 2018. It is now read-only.

Conversation

@IgnoredAmbience
Copy link
Member

As a follow-up to Alan's email to jscert-devel, here's a version of the master branch with the jsjsref work filtered out to minimise the size of the changes to be pushed publicly. (jsjsref history is fully preserved in the jsexplain repository).

There's a few jsjsref directory references in the .gitignore file history and commit history, but I think that's safe to ignore.

We should also look at merging in #39, which is now probably overdue.
Other branches that could possibly be made public are v8, and sublanguages.
I will merge in a tidied version of the condor branch (the improved test harness), once I've removed the junk commits and tested on the Imperial infrastructure.

@IgnoredAmbience IgnoredAmbience self-assigned this Dec 13, 2016
@brabalan
Copy link
Contributor

Shouldn't the tracer code go away? In particular, why do we need codemirror?

@IgnoredAmbience
Copy link
Member Author

It is already in the public code, that commit was too deep in the branch history for me to bother flattening it out. I agree that tracer can be killed, but it should be in another commit.

@brabalan
Copy link
Contributor

Yes, this is the way to go.

@IgnoredAmbience
Copy link
Member Author

Tracer nuked.

@brabalan brabalan requested a review from tilk December 14, 2016 07:56
Copy link
Contributor

@brabalan brabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I also asked Marek to take a look.

Copy link
Contributor

@tilk tilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It doesn't look like any of these changes should break my proofs.

@IgnoredAmbience IgnoredAmbience merged commit 2fbe153 into public Dec 14, 2016
@IgnoredAmbience IgnoredAmbience deleted the private-public-merge-pr branch December 14, 2016 10:01
@IgnoredAmbience
Copy link
Member Author

Ok, merged into the public branch here, and master of jscert/jscert.

I'll now swap 'public' to being the default branch here (and delete master?).

Tasks still remaining are to look at merging in #39 and decide which other branches that could possibly be made public candidates are v8, and sublanguages.

@brabalan
Copy link
Contributor

Couldn't we simply abandon (as in no longer update) this repo? We should ask @PetarMax about the sublanguage branch.

For #39 Marek has the fix in his fork, so it will be included in his pull request after he merges the new public version.

@IgnoredAmbience
Copy link
Member Author

Yes, we can abandon (except for issues that need to be closed/transferred), I will lock the master branch from any new accidental pushes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants