fix: enhance error logging for channel and sync registries #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change logging level from Debug to Warn for error messages in channel registry and sync registry files. - Improve error visibility by logging warnings instead of debug information for failed event sends. Signed-off-by: dsv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @resmoio,
I've submitted a patch that changes the logging level from Debug to Warn for error messages related to event sending failures in both the channel and sync registries.
The motivation behind this change is to improve the visibility of these errors. Given that event sending is a critical function within this application, it's essential to surface these issues more prominently. By logging these errors at the Warn level, it becomes significantly easier to identify and investigate problems when they occur.