Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-email): Improved overall experience #1306

Open
wants to merge 43 commits into
base: canary
Choose a base branch
from

Conversation

gabrielmfern
Copy link
Collaborator

Before After
Before.mov
After.mov

Why?

Generally starters will ask you what you want out of the template being created
through prompts. This is something that is generally very helpful and very powerful.

This helps a lot with the way users can get to a more meaningful
starting point quickly now instead of having to understand and figure out certain things
by themselves. Like how Tailwind should be configured and other things.

What does it change?

This PR changes the following specifically:

  • Use TypeScript with tsup to build the code
  • Adds many unit tests and breaks up code apart to make sure everything is working fine
  • Detects user project location based on prompts instead of an argument.
    • Asks if the user wants TypeScript
    • Asks if the user wants to use TailwindCSS
    • Detects weather or not the user is inside a monorepo and asks if they want the starter to add the new project as a workspace (Also allows the user to choose which workspace properly)
  • Adds new versions of the initial template
    • Typescript
    • JavaScript
    • Typescript + TailwindCSS
    • JavaScript + TailwindCSS

How can I test this?

  1. Checkout into the PR
  2. Run pnpm install and pnpm build inside of ./packages/create-email
  3. Run npm link
  4. Run npx create-email and it should run the locally built version

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 7:29pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 7:29pm

@gabrielmfern gabrielmfern added Package: create-email Package for running `npx create-email` Type: Feature New feature approved from Discussions labels Mar 6, 2024
@gabrielmfern gabrielmfern force-pushed the canary branch 2 times, most recently from eea0258 to e5d2948 Compare April 29, 2024 19:53
@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from 8a41d44 to a0a0c9a Compare July 1, 2024 13:49
@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from e001f5e to f5cf05c Compare July 3, 2024 21:41
@gabrielmfern gabrielmfern force-pushed the canary branch 2 times, most recently from d1a7c8d to 296473d Compare July 23, 2024 17:44
@gabrielmfern gabrielmfern force-pushed the canary branch 5 times, most recently from 92e6dc1 to 76bbf7b Compare September 13, 2024 14:35
@gabrielmfern gabrielmfern force-pushed the canary branch 2 times, most recently from 4473810 to ad2e6c4 Compare September 26, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: create-email Package for running `npx create-email` Type: Feature New feature approved from Discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant