Skip to content

Fix incorrect analysis report for optional function args#8321

Draft
cknitt wants to merge 8 commits into
masterfrom
fix-reanalyze
Draft

Fix incorrect analysis report for optional function args#8321
cknitt wants to merge 8 commits into
masterfrom
fix-reanalyze

Ignore optional arg wrappers as value escapes

71e38c2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 7, 2026 in 1s

74.66% (-0.01%) compared to 8cb30c7

View this Pull Request on Codecov

74.66% (-0.01%) compared to 8cb30c7

Details

Codecov Report

❌ Patch coverage is 76.62338% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.66%. Comparing base (8cb30c7) to head (71e38c2).

Files with missing lines Patch % Lines
analysis/reanalyze/src/dead_value.ml 75.55% 11 Missing ⚠️
analysis/reanalyze/src/dead_optional_args.ml 75.00% 4 Missing ⚠️
analysis/reanalyze/src/cross_file_items_store.ml 71.42% 2 Missing ⚠️
analysis/reanalyze/src/reanalyze.ml 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8321      +/-   ##
==========================================
- Coverage   74.66%   74.66%   -0.01%     
==========================================
  Files         457      457              
  Lines       62110    62174      +64     
==========================================
+ Hits        46373    46420      +47     
- Misses      15737    15754      +17     
Files with missing lines Coverage Δ
analysis/reanalyze/src/cross_file_items.ml 88.88% <100.00%> (+2.22%) ⬆️
analysis/reanalyze/src/dead_common.ml 73.38% <100.00%> (+0.10%) ⬆️
analysis/reanalyze/src/decl.ml 77.77% <ø> (ø)
analysis/reanalyze/src/reactive_merge.ml 0.00% <ø> (ø)
analysis/reanalyze/src/reanalyze.ml 48.56% <50.00%> (+<0.01%) ⬆️
analysis/reanalyze/src/cross_file_items_store.ml 81.08% <71.42%> (+1.08%) ⬆️
analysis/reanalyze/src/dead_optional_args.ml 87.69% <75.00%> (-4.31%) ⬇️
analysis/reanalyze/src/dead_value.ml 83.06% <75.55%> (-2.32%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.