Initial implementation of js-post-build in rewatch #8151
Merged
+65
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
Author
|
@cknitt any thoughts on how big of a deal the absolute path is here? |
Member
|
I agree that passing an absolute path should be clearer. |
nojaf
force-pushed
the
rewatch-js-post-build
branch
from
ac4efda to
c3f492e
Compare
zth
approved these changes
Jan 12, 2026
Member
zth
left a comment
zth
left a comment
There was a problem hiding this comment.
LGTM. Did you consider if adding tests was possible/useful?
nojaf
commented
Jan 12, 2026
| } | ||
|
|
||
| const out = await execBuildLegacy(); | ||
| const out = await execBuild(); |
cknitt
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8150
It does use the absolute path for now.