Fix crash resolving ReScript v12+ binaries - #1193
Merged
fhammerschmidt merged 1 commit intoSep 10, 2026
Merged
Conversation
findBinary passed a plain filesystem path to url.fileURLToPath, which always throws ERR_INVALID_URL, crashing the language server on startup for any ReScript >= 12.0.0-alpha.13 project. Convert the path with url.pathToFileURL instead, which also keeps the dynamic import working on Windows. Fixes rescript-lang#1181
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11656c3148
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
fhammerschmidt
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1181
The language server crashes on startup with
ERR_INVALID_URLfor any project using ReScript >= 12.0.0-alpha.13, making the extension unusable with v12. This PR fixes the binary resolution so v12+ projects load again.I ran into the issue when I was setting up the LSP with NeoVim on a fresh create-rescript-app Vite project. This change was admittedly AI-assisted, but it seemed relatively straightforward and has been manually confirmed to work at least on my setup.