Skip to content

update docs for array access to return an option #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jderochervlk
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Mar 26, 2024

@jderochervlk is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@fhammerschmidt
Copy link
Member

Thanks a lot!

This would fix #712
Would you be up to add a mention of Array.getExn as well, if somebody wants to have the old behavior back?

Also related: #825
Maybe you figure out some lines to put in the migration guide as well?

@@ -1,5 +1,5 @@
---
title: "Reserved Keyword"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sidebar title didn't match the page title or URL.

@fhammerschmidt
Copy link
Member

Well done!

@fhammerschmidt fhammerschmidt merged commit a4d6bfd into rescript-lang:master Mar 27, 2024
@jderochervlk jderochervlk deleted the array-docs branch March 27, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants