Skip to content

add vim mode setting to playground #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rbertramResi
Copy link

No description provided.

Copy link

vercel bot commented Jul 23, 2025

@rbertramResi is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Maybe you could label it "Use Vim Keymap"?

let (keyMap, setKeyMap) = React.useState(() => {
Dom.Storage2.localStorage
->Dom.Storage2.getItem("vimMode")
->Belt.Option.map(CodeMirror.KeyMap.fromString)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use Option without the Belt

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 👍 And changed the label over the toggle to "Use Vim Keymap"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants