Add Option.all & Result.all helpers#202
Closed
bloodyowl wants to merge 2 commits into
Closed
Conversation
bc9a39b to
c11c3b2
Compare
c11c3b2 to
819fb0e
Compare
Member
|
I think that if we want to add this, we should also have (This is something that I would actually already have needed in practice for the |
cknitt
reviewed
Nov 29, 2024
| "en-US", | ||
| "en-GB" | ||
| ], undefined); | ||
| ]); |
Member
There was a problem hiding this comment.
There are some unrelated changes in the test output like here - were you using a different/newer ReScript version?
Contributor
Author
|
closing as merged with rescript-lang/rescript#7181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Option.all&Result.allhelpers. The API is inspired byPromise.allwhich is pretty well known by users.