Skip to content

Include SharedWorker in WebWorkerAPI #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 28, 2025
Merged

Conversation

switch-to-gitlab
Copy link
Contributor

Closes Issue #112.

This adds bindings for the SharedWorker interface and SharedWorkerGlobalScope interface.

I also took the liberty of adding "*~" to the bottom of your .gitignore. Emacs automatically adds backup files ending in a tilde, which gets annoying if it's not in your .gitignore. Feel free to reject that, of course, but I figure other emacs users who are contributors to the project would enjoy having that there.

Let me know if you need style changes or anything. Thank you for maintaining this!

Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for this solid PR.
Apologies again for the underscore naming thing.
Could you update those, then we are good to go I think.

@switch-to-gitlab switch-to-gitlab requested review from zth and nojaf July 27, 2025 19:57
@switch-to-gitlab
Copy link
Contributor Author

(I kinda like it without the underscores, anyway tbh. ☺️)

Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! After CI ran on my main, there should be a new package published on npm!

@nojaf nojaf merged commit 2d818ca into rescript-lang:main Jul 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WebAPI Request] SharedWorker API Request
3 participants