-
Notifications
You must be signed in to change notification settings - Fork 4
Include SharedWorker in WebWorkerAPI #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…al-rescript-webapi into feature/shared-worker
Feature/shared worker
revert accidentally committed files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for this solid PR.
Apologies again for the underscore naming thing.
Could you update those, then we are good to go I think.
(I kinda like it without the underscores, anyway tbh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! After CI ran on my main, there should be a new package published on npm!
Closes Issue #112.
This adds bindings for the SharedWorker interface and SharedWorkerGlobalScope interface.
I also took the liberty of adding "*~" to the bottom of your .gitignore. Emacs automatically adds backup files ending in a tilde, which gets annoying if it's not in your .gitignore. Feel free to reject that, of course, but I figure other emacs users who are contributors to the project would enjoy having that there.
Let me know if you need style changes or anything. Thank you for maintaining this!