Urlencode client_id and client_secret #568
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From RFC 6749 on Oauth2, section 2.3.1:
This means that we should first apply urlencoding to client_id and secret, then pass them to basic auth.
Testing locally with Keycloak, a client secret that includes a
+
character is not able to successfully login, as whitespaces are replaced with+
in urlencode. When that+
character is converted into%2B
, then authentication succeeds.