Skip to content

Release #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Release #258

merged 3 commits into from
Mar 31, 2025

Conversation

HardNorth
Copy link
Member

No description provided.

@HardNorth HardNorth merged commit edc516d into master Mar 31, 2025
12 checks passed
@HardNorth HardNorth requested a review from Copilot March 31, 2025 13:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares a new release by bumping the version and introducing error-printing HTTP request classes to avoid recursive logging issues.

  • Bumped package version from 5.6.3 to 5.6.4.
  • Added ErrorPrintingHttpRequest and ErrorPrintingAsyncHttpRequest classes to handle errors and print tracebacks without causing logging recursion.
  • Updated client modules to use the new error-printing request classes and revised the changelog.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Updates package version for the new release.
reportportal_client/core/rp_responses.py Refactors JSON message retrieval in response processing.
reportportal_client/core/rp_requests.py Introduces error-printing request classes and updates docstrings.
reportportal_client/client.py Switches to using ErrorPrintingHttpRequest for logging requests.
reportportal_client/aio/client.py Switches to using ErrorPrintingAsyncHttpRequest for async logging requests.
CHANGELOG.md Documents new classes and version changes for the release.
Comments suppressed due to low confidence (1)

reportportal_client/core/rp_requests.py:148

  • Consider replacing "std.err" with "sys.stderr" or "stderr" in the docstring for clarity and consistency.
    """This is specific request object which catches any request error and prints it to the "std.err".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant