-
Notifications
You must be signed in to change notification settings - Fork 92
Release #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the next release by refactoring comparisons against the removed NOT_FOUND constant, adding request names in logging calls, and updating tests to use the rp_client fixture and a reworked DummyResponse.
- Updated tests to encode response content and standardize fixture usage.
- Refactored client and aio client modules to remove obsolete NOT_FOUND checks and add descriptive request names.
- Bumped version and updated changelog accordingly.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/test_client.py | Updated tests with encoded responses and fixture injection changes. |
tests/steps/conftest.py | Adjusted import of DummyResponse from tests.conftest. |
tests/conftest.py | Introduced DummyResponse and enhanced the rp_client fixture. |
setup.py | Incremented version from 5.6.2 to 5.6.3. |
reportportal_client/steps/init.py | Changed return of start_nested_step to explicitly return None. |
reportportal_client/logs/log_manager.py | Replaced NOT_FOUND check with a falsy check for item_id. |
reportportal_client/core/rp_responses.py | Consolidated field access via the new _get_field helper. |
reportportal_client/client.py | Removed NOT_FOUND comparisons and added names to HttpRequest calls. |
reportportal_client/aio/client.py | Similar adjustments to NOT_FOUND removal and added request names. |
reportportal_client/_internal/static/defines.py | Removed the NOT_FOUND constant as per the changelog. |
reportportal_client/_internal/aio/tasks.py | Eliminated NOT_FOUND checks in blocking_result for clarity. |
CHANGELOG.md | Updated changelog to reflect added names and removal of NOT_FOUND. |
Comments suppressed due to low confidence (1)
tests/conftest.py:33
- [nitpick] In the DummyResponse class, consider converting the 'ok' method to a property (using @Property) to better mimic the requests.Response API.
def ok(self):
No description provided.