Fix prometheus alerts #2843
Fix prometheus alerts #2843
Conversation
emosbaugh
added
the
type::feature
emosbaugh
force-pushed
the
fix-prometheus-alerts
branch
from
6b53968 to
3ae68c9
Compare
|
I need to test kube-bench to see if this violates cis benchmark |
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-2843-34abec7-prometheus-0.55.0-34.10.0-k8s-docker |
emosbaugh
force-pushed
the
fix-prometheus-alerts
branch
from
3ae68c9 to
091d848
Compare
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-2843-ca770c1-prometheus-0.55.0-34.10.0-k8s-docker |
emosbaugh
force-pushed
the
fix-prometheus-alerts
branch
from
091d848 to
8d4c570
Compare
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-2843-42f10c3-prometheus-0.55.0-34.10.0-k8s-docker |
emosbaugh
force-pushed
the
fix-prometheus-alerts
branch
from
8d4c570 to
0b562d0
Compare
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-2843-a9482e8-prometheus-0.55.0-34.10.0-k8s-docker |
emosbaugh
force-pushed
the
fix-prometheus-alerts
branch
from
0b562d0 to
069f40d
Compare
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-2843-859b9b4-prometheus-0.55.0-34.10.0-k8s-docker |
xavpaice
force-pushed
the
fix-prometheus-alerts
branch
from
d3c6767 to
53e4f3c
Compare
|
rebased against current main branch |
|
IIUC, this change is effective for k8s 1.21? Wonder if we can split out the content of addons/prometheus/0.55.0-34.10.0 from the change to templates & patches, and have a separate commit to apply that to the various addon versions? |
This was a work in progress. I made some progress on fixing a few false positive alerts but not all. I can't remember if this was only for <= 1.21 or all versions of k8s. Yes I would suggest splitting out template code. This PR is not ready and needs more work. |
What type of PR is this?
type::feature
What this PR does / why we need it:
Fixes alerts
"KubeScheduler has disappeared from Prometheus target discovery."
"KubeControllerManager has disappeared from Prometheus target discovery."
"KubeProxy has disappeared from Prometheus target discovery."
Which issue(s) this PR fixes:
Fixes NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE