Repository navigation
Bound Sandbox terminate with a cleanup budget - #45
Merged
Merged
Conversation
The SDK's terminate takes no signal, so a hung request could hold an answer that's already computed. Race it against a 10-second budget; past that, the Sandbox's provider-side timeout is the backstop. Signal support for terminate and connect-token requests is requested upstream in render-oss/sdk#31. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK's
terminatetakes no signal, so a hung terminate request in afinallyblock could hold an answer that's already computed.SandboxClient.terminatenow races the call against a 10-secondcleanupTimeoutMsbudget, retries included. Past that, the Sandbox's provider-side timeout is the backstop, andterminateQuietlylogs the failure as before.This is the small, safe part of #26. The rest (connect-token requests that ignore the caller's signal) should be fixed in the SDK instead of a custom transport in this template. It's tracked in render-oss/sdk#31, and #26 stays open until we upgrade.
Refs #26.
Made with Cursor