Repository navigation
Cite symlink targets and reject aliases into .git - #36
Merged
Merged
Conversation
…k-citation-integrity
Snapshot checkouts are clean, read-only, and detached at the manifest commit, so the file on disk is the cited blob. Resolving the symlink, recording the target path, and re-checking .git on that path closes both alias cases from the issue without spawning git from the key-holding runner. Co-authored-by: Cursor <cursoragent@cursor.com>
jacobprall
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The citation validator followed a symlink to check the file and line range, but kept the alias path. The evidence link could then point at different content than what was checked, and an alias into
.gitgot past the metadata check.inspectFilenow records the symlink target's path relative to the repository root and rejects targets inside.git.The original version of this PR read Git objects (
ls-tree,cat-file) from the runner to validate against the manifest-commit blob. That was trimmed: snapshot checkouts are clean, read-only, and detached at the manifest commit, so the file on disk is the cited blob. Not spawninggitfrom the key-holding runner is a small bonus.Tests cover contained aliases (file, chain, directory, nested directory), aliases into
.git, escaping, dangling, and cyclic links, and the evidence URL built from the target path.Runner change: takes effect after the next snapshot refresh.
Fixes #24.