-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
@remotion/web-renderer: Add audioCodec and audioBitrate options
#6170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds audio codec and bitrate customization options to the web renderer, enabling users to choose between AAC and Opus codecs with configurable quality levels.
Key changes:
- Added
audioCodecandaudioBitrateoptions torenderMediaOnWeb()with automatic browser compatibility fallback - Implemented UI controls in Studio's Web Render Modal for selecting audio codec and quality
- Added disabled item support in ComboBox components to show unavailable codec options
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/web-renderer/src/render-media-on-web.tsx |
Core implementation of audio codec selection with browser capability detection and fallback logic |
packages/web-renderer/src/mediabunny-mappings.ts |
Audio codec type definitions and mapping functions for container-codec compatibility |
packages/web-renderer/src/index.ts |
Exports new audio codec types and helper functions |
packages/studio/src/components/RenderModal/quality-options.tsx |
Reusable quality options helper for audio and video quality selectors |
packages/studio/src/components/RenderModal/WebRenderModalPicture.tsx |
Refactored to use shared quality options helper |
packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx |
Audio tab UI with codec and quality selectors, browser compatibility detection |
packages/studio/src/components/RenderModal/WebRenderModal.tsx |
State management and integration of audio codec options |
packages/studio/src/components/NewComposition/MenuContent.tsx |
Enhanced keyboard navigation to skip disabled items |
packages/studio/src/components/NewComposition/ComboBox.tsx |
Added disabled property to ComboboxValue type |
packages/studio/src/components/Menu/MenuSubItem.tsx |
Visual styling and interaction handling for disabled menu items |
packages/docs/docs/web-renderer/render-media-on-web.mdx |
Documentation for new audioCodec and audioBitrate options |
packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Copilot <[email protected]>
…m/remotion-dev/remotion into feature/web-renderer-audio-codecs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.
packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
Outdated
Show resolved
Hide resolved
JonnyBurger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM!
packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
Outdated
Show resolved
Hide resolved
…feature/web-renderer-audio-codecs
…oCodec` and notice for the user
…feature/web-renderer-audio-codecs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
Outdated
Show resolved
Hide resolved
packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
Outdated
Show resolved
Hide resolved
JonnyBurger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality! Thanks a lot 🙌
Fixes #6047
audioCodecoption torenderMediaOnWeb()with support for'aac'and'opus'codecsaudioBitrateoption to control audio quality ('very-low'|'low'|'medium'|'high'|'very-high')