feat(onboarding) - add new step to select country #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at-lets-you-select-a
gabrielseco
changed the title
eng-almeida
approved these changes
May 30, 2025
src/flows/Onboarding/hooks.ts
Outdated
Comment on lines
507
to
509
| return parseJSFToValidate(values, selectCountryForm?.fields, { | ||
| isPartialValidation: true, | ||
| }); |
There was a problem hiding this comment.
Do we need to parse the country values?
There was a problem hiding this comment.
I did for what I thought it was consistency, I've removed it
src/flows/Onboarding/hooks.ts
Outdated
| const [internalCountryCode, setInternalCountryCode] = useState<string | null>( | ||
| null, | ||
| ); | ||
| const { data: countries, isLoading: isLoadingCountries } = useCountries(); |
There was a problem hiding this comment.
Can we build a hook that aggregates all the logic to build the country dropdown? It could do what useCountries already does and in the select callback run createHeadlessForm for the local schema
src/flows/Onboarding/hooks.ts
Outdated
| @@ -554,6 +637,13 @@ export const useOnboarding = ({ | |||
| * @returns Validation result or null if no schema is available | |||
| */ | |||
| handleValidation: (values: FieldValues) => { | |||
| if (stepState.currentStep.name === 'select_country') { | |||
| const parsedValues = parseJSFToValidate( | |||
There was a problem hiding this comment.
Same question, do we need to parse the country value?
eng-almeida
reviewed
Jun 2, 2025
| case 'basic_information': { | ||
| if (!internalEmploymentId) { | ||
| const notLoadedEmployment = |
There was a problem hiding this comment.
We should be consistent in the naming, so booleans should start with is, eg isEmploymentLoaded
Co-authored-by: João Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new step to select country and remove the countryId from the props.
We could discuss later if we could have countryId as optional to preselect the country fields
You can select a country and the onboarding starts as before
If you decide to load an onboarding and you change countries, in the basic information step we don't update the employment, we just create a new one.