fix(fieldset): Fix handleValidation for undefined fieldset #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denatys
force-pushed
the
fix-validation-for-fieldsets
branch
2 times, most recently
from
cd12d91 to
4eb3067
Compare
denatys
force-pushed
the
fix-validation-for-fieldsets
branch
from
4eb3067 to
ebdd77c
Compare
denatys
changed the title
denatys
changed the title
Ensure `getField` handles undefined `formFields` by providing a fallback to an empty array. Also, properly check if `currentField` exists before accessing its `inputType` property to prevent errors. This improves robustness when processing form field values.
Simplify and streamline the logic for determining field values and types when validating `if` conditions. Removes redundant variable declarations and improves readability without altering functionality.
Refactored the value assignment logic to use the nullish coalescing operator for improved readability and consistency. This change ensures clearer handling of formValues and default values for FIELDSET types. No functional behavior is altered.
|
@sandrina-p hi, can you review PR, my users waiting for this ;) |
|
Hi @denatys! We are building the next major version of JSF, which includes/will include your bugfix. For that reason we won't review your PR, so we can focus on shipping the next version as soon as possible. In the meantime, here's a dev release based on this PR to unblock you. We hope that's okay for now. Thank you! |
|
@dragidavid I need changes from v0.11.13-beta.0 can you make new version with my fix? |
|
Hey @denatys - sorry for the wait! Just released a new version for you under
Feel free to ping me if you need new dev releases while we're working on the next major version for the package. Happy to assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleValidation({}) for fieldsets is not working. But working fine for createHeadless form