-
Notifications
You must be signed in to change notification settings - Fork 24
feat(fetch): add Response.json
static method
#10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 857eec9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d819f93
to
f8855c9
Compare
As far as I know, there's no I'm solving a similar convenience issue in MSW, and you can draw some inspiration from there. |
it's in the spec and implemented in chrome, so it really just makes our polyfill closer to the spec |
@mcansh, a good point, I must've been using a really old version of Chrome so it didn't show up when I checked this. Thanks for correcting me! |
d661763
to
3f363c1
Compare
Response.json
static method
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
[skip ci] Signed-off-by: Logan McAnsh <[email protected]>
7c9a525
to
857eec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
remix-run/remix#3308
======================================================================================
confirmed working with
npm link
and importing Response from@remix-run/web-fetch