-
Notifications
You must be signed in to change notification settings - Fork 2.6k
v2: handle root path with basename
when using Single Fetch
#10636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dc8a1ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @ThisIsAreku, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
fa20f51
to
94c02cc
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
94c02cc
to
0041f15
Compare
0041f15
to
dc8a1ee
Compare
basename
basename
basename
when using Single Fetch
Can this be updated to instead port over the final solution in v7 from remix-run/react-router#12898? That way we're not accessing global window values from deep inside other code and instead minimize/localize our access to window globals |
Using
v3_singleFetch
with abasename
set (i.e./foo/
), a data loader should request/foo/_root.data
instead of/foo.data
, as the later is outside the basename.This PR port the patch of remix-run/react-router#12295 (comment) into the remix v2 branch
Closes: #10212