-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
feat: prerendering with vite preview server #14650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat: prerendering with vite preview server #14650
Conversation
To detect resource routes without loading server modules during build
Run vite prerender tests with unstable_previewServerPrerendering enabled and disabled
|
|
Hi @edmundhung, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
RFC #14651
The diffs look huge but half of them are tests, as I am running the vite prerender tests with the new unstable flag as well to make sure both code paths work. The existing prerender logic is untouched. Happy to refactor if you would prefer consolidating them.
Feel free to review commit by commit. I have also added a
/staticroute to the cloudflare playground as a working example.Notes
hasDefaultExportto route manifest to detect resource routes without loading server modules.__spa-fallback.htmlfirst and rename it toindex.htmlafter prerendering if the index page is not prerendered.